Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: fix inconsistenty of alias and db for query iterator(#39045) #39301

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

MrPresent-Han
Copy link
Contributor

related: #39045
pr: #39248

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.43%. Comparing base (995d5e1) to head (13ae267).
Report is 5 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/task_query.go 23.07% 8 Missing and 2 partials ⚠️
internal/proxy/search_util.go 87.50% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39301      +/-   ##
==========================================
- Coverage   80.44%   80.43%   -0.01%     
==========================================
  Files        1079     1079              
  Lines      169909   169928      +19     
==========================================
+ Hits       136678   136682       +4     
- Misses      28730    28745      +15     
  Partials     4501     4501              
Files with missing lines Coverage Δ
internal/proxy/task.go 81.59% <ø> (ø)
internal/proxy/task_search.go 74.74% <100.00%> (+0.12%) ⬆️
internal/proxy/search_util.go 80.76% <87.50%> (+0.22%) ⬆️
internal/proxy/task_query.go 78.73% <23.07%> (-1.43%) ⬇️

... and 26 files with indirect coverage changes

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 16, 2025
@yanliang567 yanliang567 added this to the 2.4.21 milestone Jan 16, 2025
@PwzXxm
Copy link
Contributor

PwzXxm commented Jan 16, 2025

/lgtm

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 477425d into milvus-io:2.4 Jan 16, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants