Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support restful & go sdk for Int8Vector #39278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Jan 15, 2025

Issue: #38666

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cydrain
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file area/test sig/testing labels Jan 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (3a6408b) to head (3747fd7).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3a6408b) and HEAD (3747fd7). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3a6408b) HEAD (3747fd7)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39278       +/-   ##
===========================================
- Coverage   81.07%   69.65%   -11.43%     
===========================================
  Files        1404      299     -1105     
  Lines      198272    26799   -171473     
===========================================
- Hits       160752    18667   -142085     
+ Misses      31867     8132    -23735     
+ Partials     5653        0     -5653     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.65% <ø> (ø)
Go ∅ <ø> (∅)

see 1105 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_support_int8_vector_sdk branch from 5070779 to 3747fd7 Compare January 15, 2025 07:05
Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file area/test dco-passed DCO check passed. kind/feature Issues related to feature request from users sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants