-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Remove not inuse binlog iterators #39243
base: master
Are you sure you want to change the base?
Conversation
1. Remove datanode/iterators/binlog_iterator 2. Remove storage/binlog_iterator/MergeIterator See also: milvus-io#39242 Signed-off-by: yangxuan <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: XuanYang-cn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39243 +/- ##
==========================================
- Coverage 81.08% 81.03% -0.05%
==========================================
Files 1405 1404 -1
Lines 198290 198183 -107
==========================================
- Hits 160790 160605 -185
- Misses 31858 31915 +57
- Partials 5642 5663 +21
|
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn go-sdk check failed, comment |
See also: #39242