Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove not inuse binlog iterators #39243

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

XuanYang-cn
Copy link
Contributor

  1. Remove datanode/iterators/binlog_iterator
  2. Remove storage/binlog_iterator/MergeIterator

See also: #39242

1. Remove datanode/iterators/binlog_iterator
2. Remove storage/binlog_iterator/MergeIterator

See also: milvus-io#39242

Signed-off-by: yangxuan <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (7addeea) to head (d510ea6).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39243      +/-   ##
==========================================
- Coverage   81.08%   81.03%   -0.05%     
==========================================
  Files        1405     1404       -1     
  Lines      198290   198183     -107     
==========================================
- Hits       160790   160605     -185     
- Misses      31858    31915      +57     
- Partials     5642     5663      +21     
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.65% <ø> (ø)
Go 82.95% <ø> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/storage/binlog_iterator.go 93.33% <ø> (-0.61%) ⬇️

... and 31 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 15, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants