Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Fix standby mixcoord start failed #39240

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

When standby transitions to active, the component state changes to Initialize. If the initialization takes too long (exceeding the liveness probe's maximum retries), the standby pod is stopped and fails to start.
This PR removes the Initialize state during standby transitions in rolling upgrades. The state now switches directly from standby to healthy, preventing health check failures.

issue: #37630

pr: #38308

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 14, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (9a63383) to head (253b938).
Report is 8 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39240   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files        1394     1394           
  Lines      196509   196576   +67     
=======================================
+ Hits       159313   159381   +68     
+ Misses      31595    31586    -9     
- Partials     5601     5609    +8     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.53% <ø> (ø)
Go 83.04% <91.13%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.58% <100.00%> (+0.12%) ⬆️
internal/querycoordv2/server.go 79.00% <100.00%> (+0.05%) ⬆️
internal/rootcoord/root_coord.go 90.08% <100.00%> (-0.12%) ⬇️

... and 34 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. do-not-merge/hold kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants