Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added code for Internal-tls #36865

Merged
merged 6 commits into from
Nov 19, 2024

fix ut

2a62871
Select commit
Loading
Failed to load commit list.
Merged

feat: Added code for Internal-tls #36865

fix ut
2a62871
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 19, 2024 in 1s

81.03% (target 77.00%)

View this Pull Request on Codecov

81.03% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 72.18543% with 42 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (3bbbf3c) to head (2a62871).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/distributed/utils/util.go 67.56% 9 Missing and 3 partials ⚠️
internal/distributed/datacoord/client/client.go 50.00% 3 Missing and 1 partial ⚠️
internal/distributed/datanode/client/client.go 50.00% 3 Missing and 1 partial ⚠️
internal/distributed/indexnode/client/client.go 50.00% 3 Missing and 1 partial ⚠️
internal/distributed/proxy/client/client.go 50.00% 3 Missing and 1 partial ⚠️
internal/distributed/querycoord/client/client.go 50.00% 3 Missing and 1 partial ⚠️
internal/distributed/querynode/client/client.go 50.00% 3 Missing and 1 partial ⚠️
internal/distributed/rootcoord/client/client.go 50.00% 3 Missing and 1 partial ⚠️
internal/util/mock/grpcclient.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36865      +/-   ##
==========================================
- Coverage   82.88%   81.03%   -1.85%     
==========================================
  Files        1067     1356     +289     
  Lines      164522   190146   +25624     
==========================================
+ Hits       136362   154084   +17722     
- Misses      22698    30592    +7894     
- Partials     5462     5470       +8     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <ø> (∅)
Go 83.20% <72.18%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/distributed/datacoord/service.go 90.44% <100.00%> (+1.18%) ⬆️
internal/distributed/datanode/service.go 82.57% <100.00%> (+0.14%) ⬆️
internal/distributed/indexnode/service.go 75.53% <100.00%> (+0.26%) ⬆️
internal/distributed/proxy/service.go 85.36% <100.00%> (+0.04%) ⬆️
internal/distributed/querycoord/service.go 77.20% <100.00%> (+0.16%) ⬆️
internal/distributed/querynode/service.go 82.48% <100.00%> (+0.16%) ⬆️
internal/distributed/rootcoord/service.go 79.80% <100.00%> (+0.13%) ⬆️
internal/util/grpcclient/client.go 98.18% <100.00%> (+11.27%) ⬆️
pkg/util/paramtable/base_table.go 79.87% <ø> (ø)
pkg/util/paramtable/component_param.go 98.35% <100.00%> (+<0.01%) ⬆️
... and 10 more

... and 321 files with indirect coverage changes

---- 🚨 Try these New Features: