[enhance]: use byte array for packed kv meta to reduce meta size #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tedxu
reviewed
Sep 10, 2024
| kv_metadata_->Append("row_group_sizes", value.substr(0, value.length() - 1)); | ||
| std::vector<uint8_t> byteArray(row_group_sizes_.size() * sizeof(size_t)); | ||
| std::memcpy(byteArray.data(), row_group_sizes_.data(), byteArray.size()); | ||
| kv_metadata_->Append("row_group_sizes", std::string(byteArray.begin(), byteArray.end())); |
There was a problem hiding this comment.
nit: make "row_group_sizes" global constant.
cpp/src/packed/reader.cpp
Outdated
| sizes.push_back(std::stoll(token)); | ||
| } | ||
| return sizes; | ||
| auto parse_size = [&](const std::string& input) -> std::vector<size_t> { |
There was a problem hiding this comment.
nit: the code of serialize and deserialize of row group size can be put together in some utility files.
cpp/src/packed/reader.cpp
Outdated
| std::vector<uint8_t> byteArray = std::vector<uint8_t>(input.begin(), input.end()); | ||
| std::vector<size_t> vec(byteArray.size() / sizeof(size_t)); | ||
| std::memcpy(vec.data(), byteArray.data(), byteArray.size()); | ||
| return vec; | ||
| }; | ||
| for (int i = 0; i < file_readers_.size(); ++i) { | ||
| row_group_sizes_.push_back( |
There was a problem hiding this comment.
->value(0): don't do that, the key_value_metadata field may have multiple entries.
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
meta
branch
from
b6526dc to
65c1505
Compare
shaoting-huang
changed the title
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #127