enhance: optimize kv metadata and fix first large row group #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaoting-huang
force-pushed
the
optimize
branch
from
0a9c4dd to
16c0c90
Compare
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
optimize
branch
from
16c0c90 to
97a4936
Compare
tedxu
reviewed
Sep 3, 2024
| return Status::OK(); | ||
| } | ||
|
|
||
| int64_t ParquetFileWriter::count() { return count_; } | ||
|
|
||
| Status ParquetFileWriter::Close() { | ||
| std::stringstream ss; |
There was a problem hiding this comment.
Can we just write bytes rather than comma-separated-strings?
| for (int i = 0; i < record->num_columns(); ++i) { | ||
| std::shared_ptr<arrow::Array> column = record->column(i); | ||
| if (!column) { | ||
| throw std::runtime_error("Column is null"); |
There was a problem hiding this comment.
The error handling is supposed to be either exception or return value of type Result, not both. BTW, I don't think it's necessary to check null here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #127