change ldflags to fix UT failures

Signed-off-by: Ted Xu <[email protected]>
milvus-io · Oct 29, 2024 · 77b1451 · 77b1451
1 parent fc61560
commit 77b1451
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/go/Makefile b/go/Makefile
@@ -14,10 +14,10 @@ LDFLAGS             += $(addprefix -L, $(MILVUS_STORAGE_LD_DIR))
 .PHONY: build 
 
 build:
-	CGO_CFLAGS="$(CPPFLAGS)" CGO_LDFLAGS="$(LDFLAGS)" go build ./...
+	CGO_CFLAGS="$(CPPFLAGS)" CGO_LDFLAGS="$(LDFLAGS) -lmilvus-storage" go build ./...
 
 test:
-	CGO_CFLAGS="$(CPPFLAGS)" CGO_LDFLAGS="$(LDFLAGS) -Wl,-rpath,$(MILVUS_STORAGE_LD_DIR)" go test -timeout 30s ./...
+	CGO_CFLAGS="$(CPPFLAGS)" CGO_LDFLAGS="$(LDFLAGS) -Wl,-rpath,$(MILVUS_STORAGE_LD_DIR) -lmilvus-storage" go test -timeout 30s ./...
 proto:
 	mkdir -p proto/manifest_proto
 	mkdir -p proto/schema_proto

diff --git a/go/packed/packed.go b/go/packed/packed.go
@@ -15,8 +15,6 @@
 package packed
 
 /*
-#cgo LDFLAGS: -lmilvus-storage
-
 #include <stdlib.h>
 #include "milvus-storage/packed/reader_c.h"
 #include "arrow/c/abi.h"