fix: Make custom DialOption overwrite default ones #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also milvus-io#699 Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
added
approved
|
/kind bug |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 71.85% 71.94% +0.08%
==========================================
Files 51 51
Lines 4758 4759 +1
==========================================
+ Hits 3419 3424 +5
+ Misses 1217 1212 -5
- Partials 122 123 +1
|
|
/lgtm |
sre-ci-robot
pushed a commit
to milvus-io/milvus
that referenced
this pull request
May 17, 2024
Related to #31293 See also milvus-io/milvus-sdk-go#704 milvus-io/milvus-sdk-go#711 milvus-io/milvus-sdk-go#713 milvus-io/milvus-sdk-go#721 milvus-io/milvus-sdk-go#732 milvus-io/milvus-sdk-go#739 milvus-io/milvus-sdk-go#748 --------- Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #699