Add feder proto #117
Merged
Add feder proto #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiaocai2333 Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”) |
mergify
bot
added
do-not-merge/missing-related-issue
ci-passed
and removed
do-not-merge/missing-related-issue
labels
xiaocai2333
force-pushed
the
add_feder_proto
branch
2 times, most recently
from
e83837a to
862b192
Compare
czs007
reviewed
Mar 20, 2023
proto/common.proto
Outdated
| @@ -177,6 +177,8 @@ enum MsgType { | |||
| HandoffSegments = 254; | |||
| LoadBalanceSegments = 255; | |||
| DescribeSegments = 256; | |||
| ListIndexedSegment = 257; | |||
There was a problem hiding this comment.
suggest to rename to FederListIndexedSegment
czs007
reviewed
Mar 20, 2023
proto/milvus.proto
Outdated
| @@ -1517,3 +1521,27 @@ message RenameCollectionRequest { | |||
| string oldName = 3; | |||
| string newName = 4; | |||
| } | |||
|
|
|||
| message ListIndexedSegmentRequest { | |||
czs007
reviewed
Mar 20, 2023
proto/milvus.proto
Outdated
| string index_name = 3; | ||
| } | ||
|
|
||
| message ListIndexedSegmentResponse { |
czs007
reviewed
Mar 20, 2023
proto/milvus.proto
Outdated
| repeated int64 segmentIDs = 2; | ||
| } | ||
|
|
||
| message DescribeSegmentIndexDataRequest { |
xiaocai2333
force-pushed
the
add_feder_proto
branch
from
862b192 to
e3c9326
Compare
Signed-off-by: cai.zhang <[email protected]>
xiaocai2333
force-pushed
the
add_feder_proto
branch
from
e3c9326 to
06f545d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, xiaocai2333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yah01
pushed a commit
to yah01/milvus-proto
that referenced
this pull request
Apr 11, 2023
Signed-off-by: cai.zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cai.zhang [email protected]
Co-author: zhenshan.cao [email protected]
issue: #118