enhance: Make pprof fetching run in parallel #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birdwatcher shall put history log in workspace folder. If the folder does not exist, history logging will fail. This PR make birdwatcher to try to create folder by default and try it best to enable history logging Signed-off-by: Congqi Xia <[email protected]>
Fetching pprof may cause lots of time especially when the type is set to `profile` since the birdwatcher will fetch each component for 30 seconds This PR make this procedure run in parallel to improve the performance of `pprof` command Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching pprof may cause lots of time especially when the type is set to
profilesince the birdwatcher will fetch each component for 30 secondsThis PR make this procedure run in parallel to improve the performance
of
pprofcommand