Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix panicking in remove collection-drop when collection not exist #250

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

congqixia
Copy link
Collaborator

When collection with provided id not exist, birdwatcher will have NPE panic

Also add log and return fast when list collection fails in same command

When collection with provided id not exist, birdwatcher will have NPE
panic

Also add log and return fast when list collection fails in same command

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aoiasd
Copy link
Contributor

aoiasd commented Mar 14, 2024

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 14, 2024
@sre-ci-robot sre-ci-robot merged commit cbb1da9 into milvus-io:v1.0.x Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants