feat: UIG-2910 - vl-table-next - introductie component #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goldflow
force-pushed
the
feature/UIG-2910-data-table-to-lit
branch
from
9227f18 to
c333067
Compare
Goldflow
changed the title
Goldflow
force-pushed
the
feature/UIG-2910-data-table-to-lit
branch
from
c333067 to
209ff87
Compare
Storybook verbeterd, cypress uitgebreid & meta-data aangepast.
Goldflow
force-pushed
the
feature/UIG-2910-data-table-to-lit
branch
from
209ff87 to
3c134d4
Compare
kspeltix
requested changes
Dec 16, 2024
| @@ -11,7 +11,7 @@ import * as VlSearchFilterStories from './vl-search-filter.stories'; | |||
| <VluxAlert type="info"> | |||
| {` | |||
| In de v2 versie van deze component gebruik je hem via de custom-tag, de interne implementatie is voor de rest gelijk gebleven aan deze van de v1 versie. | |||
| In v3 zal deze component grondig herwerkt worden; in de context van een herwerking van de vl-data-table. | |||
| In v3 zal deze component grondig herwerkt worden; in de context van een herwerking van de vl-table. | |||
There was a problem hiding this comment.
In zou niet over v3 spreken, ik zou eerder zeggen: In de toekomst
| matrix: { | ||
| name: 'matrix', | ||
| description: | ||
| 'Attribuut wordt gebruikt om data in 2 dimensies te tonen. Zowel de rijen als de kolommen krijgen een titel. Deze titels worden gescheiden door een dikke lijn.', |
There was a problem hiding this comment.
max 120 characters en dan een enter
| <VluxAlert type="info"> | ||
| {` | ||
| In de v2 versie van deze component gebruik je hem via de custom-tag, de interne implementatie is voor de rest gelijk gebleven aan deze van de v1 versie. | ||
| In v3 zal deze component grondig herwerkt worden; in de context van een herwerking van de vl-table. |
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <td data-title="Entry Header 1">Entry line 1</td> |
There was a problem hiding this comment.
data-title, het lijkt mij niet dat er een data-title attribuut bestaat
| <thead> | ||
| <tr> | ||
| <th>Name</th> | ||
|
|
There was a problem hiding this comment.
al die blanco lijnen maken het vooral meer ruimte innemen
| return this.querySelector('caption'); | ||
| } | ||
|
|
||
| private get _headHeaderElements(): HTMLTableCellElement[] { |
|
|
||
| /* from assets */ | ||
|
|
||
| .vl-table-next { |
| width: 100%; | ||
| max-width: 100%; | ||
| } | ||
| .vl-table-next caption { |
There was a problem hiding this comment.
normaal zet je zo graag blanco lijnen
| }); | ||
| }); | ||
|
|
||
| const mountExpandable = ({ |
There was a problem hiding this comment.
normaal niet, maar in dit geval misschien de te mounten code en utility methodes in een apart bestand ernaast zetten?
| @@ -31,8 +31,8 @@ describe('valideer de volledigheid van de gegenereerde web-types', () => { | |||
| expect(elementWTWithoutWC).toStrictEqual([]); | |||
| }); | |||
| it('components - valideer de volledigheid van de web-types', () => { | |||
| expect(componentWCNameCount).toEqual(92); | |||
| expect(componentWTNameCount).toEqual(73); | |||
| expect(componentWCNameCount).toEqual(93); | |||
There was a problem hiding this comment.
als je rebased tov develop zal dit ook aangepast moeten worden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook verbeterd, cypress uitgebreid & meta-data aangepast.
Jira
Bamboo