Skip to content

Commit

Permalink
remove redundant keep_last() (#166)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikeferguson committed Sep 26, 2024
1 parent 4919b52 commit 4c559be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion robot_calibration/src/finders/led_finder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ bool LedFinder::init(const std::string& name,
topic_name = node->declare_parameter<std::string>(name + ".topic", name + "/points");
subscriber_ = node->create_subscription<sensor_msgs::msg::PointCloud2>(
topic_name,
rclcpp::QoS(1).best_effort().keep_last(1),
rclcpp::QoS(1).best_effort(),
std::bind(&LedFinder::cameraCallback, this, std::placeholders::_1));

// Publish where LEDs were seen
Expand Down
2 changes: 1 addition & 1 deletion robot_calibration/src/finders/plane_finder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ bool PlaneFinder::init(const std::string& name,
node->declare_parameter<std::string>(name + ".topic", name + "/points");
subscriber_ = node->create_subscription<sensor_msgs::msg::PointCloud2>(
topic_name,
rclcpp::QoS(1).best_effort().keep_last(1),
rclcpp::QoS(1).best_effort(),
std::bind(&PlaneFinder::cameraCallback, this, std::placeholders::_1));

// Name of the sensor model that will be used during optimization
Expand Down
2 changes: 1 addition & 1 deletion robot_calibration/src/finders/scan_finder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ bool ScanFinder::init(const std::string& name,
topic_name = node->declare_parameter<std::string>(name + ".topic", name + "/scan");
subscriber_ = node->create_subscription<sensor_msgs::msg::LaserScan>(
topic_name,
rclcpp::QoS(1).best_effort().keep_last(1),
rclcpp::QoS(1).best_effort(),
std::bind(&ScanFinder::scanCallback, this, std::placeholders::_1));

// Name of the sensor model that will be used during optimization
Expand Down

0 comments on commit 4c559be

Please sign in to comment.