Fixed issue for orphan items for sitecore 10.4 #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue for orphan items for sitecore 10.4
muso31
reviewed
Aug 30, 2024
| @@ -36,6 +36,7 @@ public static string GetItemUrl(Item item, UrlOptions urlOptions) | |||
| { | |||
| #if SC104 | |||
| if (item?.Paths == null) return string.Empty; | |||
| if (item?.Paths.FullPath.Contains("[orphan]") && item?.Parent == null) return string.Empty; | |||
There was a problem hiding this comment.
item?.Paths.FullPath is an expensive operation. This also contains magic strings.
There was a problem hiding this comment.
@muso31 Issue is coming for orphan items where item.parent is null but we cannot add only this check because for root item also parent is null. So added check for fullpath "[orphan]/renderingParameters"
There was a problem hiding this comment.
@muso31 Thanks for flagging. Replaced item?.Paths.FullPath check with item?.Paths.IsFullyQualified. This will come false for all orphan items.
robmaas
reviewed
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue for orphan items for sitecore 10.4