Maintain order when using inline maps and lists #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntain order of keys when expressing maps and lists inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, awesome tool. I just recently starting messing around with MVEL.
I sent an email to the user mailing list this morning regarding the possibility of switching the parser's Map implementation from HashMap to LinkedHashMap so that the order of keys are maintained based on insertion.
My primary use case this functionality was so that I could have a nice syntax to build maps for a JSON serializer. For REST APIs, I prefer when the JSON keys are ordered in a predictable way and are consistent with API documentation.
This pull request has what I think are the necessary changes, and it includes a test that confirms the order works (test would break if HashMap implementation was kept).