#82: Implement custom delay strategy support #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #82
@mike-marcacci Sketch implementation of custom retry strategy. I've though about few options & decided to go with Strategy option since I decided to minimise changes to lock code, and best approach looked like this to me:
After reviewing implementation I had a second thought that it can be simplified with just passing some
retryDelays: Array<number>
parameter to config directly, and instead of strategy as object use function to generate arbitrary delay values.e.g:
being just passing an array:
It feels to me that it's even better considering overall
node-redlock
strive to simplicity 👍 Waiting for feedback.