chore(deps): update dependency node-forge to v1 [security] - abandoned #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/npm-node-forge-vulnerability
branch
from
83d3040 to
6c2d846
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
renovate
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.10.0->1.3.0GitHub Vulnerability Alerts
GHSA-5rrq-pxf6-6jx5
Impact
The
forge.debugAPI had a potential prototype pollution issue if called with untrusted input. The API was only used for internal debug purposes in a safe way and never documented or advertised. It is suspected that uses of this API, if any exist, would likely not have used untrusted inputs in a vulnerable way.Patches
The
forge.debugAPI and related functions were removed in 1.0.0.Workarounds
Don't use the
forge.debugAPI directly or indirectly with untrusted input.References
For more information
If you have any questions or comments about this advisory:
GHSA-gf8q-jrpm-jvxq
Impact
The regex used for the
forge.util.parseUrlAPI would not properly parse certain inputs resulting in a parsed data structure that could lead to undesired behavior.Patches
forge.util.parseUrland other very old related URL APIs were removed in 1.0.0 in favor of letting applications use the more modern WHATWG URL Standard API.Workarounds
Ensure code does not directly or indirectly call
forge.util.parseUrlwith untrusted input.References
For more information
If you have any questions or comments about this advisory:
CVE-2022-0122
parseUrl functionality in node-forge mishandles certain uses of backslash such as https:///\ and interprets the URI as a relative path.
CVE-2022-24772
Impact
RSA PKCS#1 v1.5 signature verification code does not check for tailing garbage bytes after decoding a
DigestInfoASN.1 structure. This can allow padding bytes to be removed and garbage data added to forge a signature when a low public exponent is being used.Patches
The issue has been addressed in
node-forge1.3.0.References
For more information, please see
"Bleichenbacher's RSA signature forgery based on implementation error"
by Hal Finney.
For more information
If you have any questions or comments about this advisory:
CVE-2022-24771
Impact
RSA PKCS#1 v1.5 signature verification code is lenient in checking the digest algorithm structure. This can allow a crafted structure that steals padding bytes and uses unchecked portion of the PKCS#1 encoded message to forge a signature when a low public exponent is being used.
Patches
The issue has been addressed in
node-forge1.3.0.References
For more information, please see
"Bleichenbacher's RSA signature forgery based on implementation error"
by Hal Finney.
For more information
If you have any questions or comments about this advisory:
CVE-2022-24773
Impact
RSA PKCS#1 v1.5 signature verification code is not properly checking
DigestInfofor a proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.Patches
The issue has been addressed in
node-forge1.3.0.For more information
If you have any questions or comments about this advisory:
Release Notes
digitalbazaar/forge
v1.3.0Compare Source
Security
Yahyazadeh ([email protected]).
digestAlgorithmstructure can lead tosignature forgery.
allow a crafted structure that steals padding bytes and uses unchecked
portion of the PKCS#1 encoded message to forge a signature when a low
public exponent is being used. For more information, please see
"Bleichenbacher's RSA signature forgery based on implementation
error"
by Hal Finney.
forgery.
DigestInfoASN.1 structure. This can allow padding bytes to be removedand garbage data added to forge a signature when a low public exponent is
being used. For more information, please see "Bleichenbacher's RSA
signature forgery based on implementation
error"
by Hal Finney.
DigestInfois not properly checked for proper ASN.1 structure. This canlead to successful verification with signatures that contain invalid
structures but a valid digest.
Fixed
fromDeris now more strict and will default to ensuring all inputbytes are parsed or throw an error. A new option
parseAllBytescan disablethis behavior.
security issues with crafted inputs. It is possible that code doing custom
DER parsing may need to adapt to this new behavior and optional flag.
RSASSA-PKCS-v1_5DigestInfodata. Additionally check that the hashalgorithm identifier is a known value from RFC 8017
PKCS1-v1-5DigestAlgorithms. An invalidDigestInfoor algorithm identifierwill now throw an error.
since it could lead to security issues with crafted inputs. It is possible
that code may have to handle the errors from these stricter checks.
Added
identifiers:
1.2.840.113549.2.2/md22.16.840.1.101.3.4.2.4/sha2242.16.840.1.101.3.4.2.5/sha512-2242.16.840.1.101.3.4.2.6/sha512-256v1.2.1Compare Source
Fixed
reporting.
URLSearchParams.v1.2.0Compare Source
Fixed
message.
Added
1.3.14.3.2.29 / sha1WithRSASignaturefor sha1 withRSA. Considered a deprecated equivalent to
1.2.840.113549.1.1.5 / sha1WithRSAEncryption. See discussion andlinks.
Changed
digest given an signature algorithm OID. Add helper function to verify
signatures.
v1.1.0Compare Source
Fixed
behavior of openssl.
CERTIFICATE REQUEST" handled as "BEGIN CERTIFICATE REQUEST".
v1.0.0Compare Source
Notes
code (unrelated to the much wider used cryptography code). The automated and
manual test coverage for this code is weak at best. Issues or patches to
update the code or tests would be appreciated.
Removed
forge.debugAPI. The API has thepotential for prototype pollution. This API was only briefly used by the
maintainers for internal project debug purposes and was never intended to be
used with untrusted user inputs. This API was not documented or advertised
and is being removed rather than fixed.
forge.util.parseUrl()(andforge.http.parseUrlalias) and use the WHATWG URLStandard.
URLis supported by modern browersand modern Node.js. This change is needed to address URL parsing security
issues. If
forge.util.parseUrl()is used directly or throughforge.xhrorforge.httpAPIs, and support is needed for environments withoutURLsupport, then a polyfill must be used.
forge.taskAPI. This API was never used, documented,or advertised by the maintainers. If anyone was using this API and wishes to
continue development it in other project, please let the maintainers know.
Due to use in the test suite, a modified version is located in
tests/support/.forge.util.makeLink,forge.util.makeRequest,forge.util.parseFragment,forge.util.getQueryVariables. Replace withURL,URLSearchParams, and custom code as needed.Changed
masterbranch tomain.with
v. Other tools, scripts, or scanners may need to adapt.forge-dist. Install using
another method.
Added
surname,title, andgivenName.Fixed
serialNametoserialNumber.Depending on how applications used this id to name association it could cause
compatibility issues.
Configuration
📅 Schedule: Branch creation - "" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.