Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing v1 embedding to fix compile on flutter 3.27 #1644

Merged
merged 2 commits into from
Dec 16, 2024
Merged

removing v1 embedding to fix compile on flutter 3.27 #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
668544f
removing v1 embedding
abdelaziz-mahdy Dec 11, 2024
3b299bb
update version and change log
abdelaziz-mahdy Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 8.1.6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should Add an new version instead of removing this one, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you mean, I did add a new version?

If you are talking about v1 embedding it has been deprecated for.a while Now, it should be removed anyway

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I know what he mean, you didn't add specific new version on this changelog like the 8.1.5 one. So better you add it as 8.1.6 and the package owner should merge this pr then publish to pub.dev

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer but the changelog looks just fine to me.

Copy link

@InvertedX InvertedX Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on my setup, and everything works as expected. Great job! @abdelaziz-mahdy

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you mean, I did add a new version?

Sorry, my bad... I did not have my coffee yet when I reviewed :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping version is good until another PR with version bump is merged. It is up to the maintainer if he requires version bump as part of the PR. Personally I do the version bump in the release branch dedicated the version release. I know that for example Flutter community plugins require version bump (I've been through it and got hindered several times due to other PRs with version merging and having to resolve conflict and rebase).
Just merge this PR (🙏🏻 🙏🏻 🙏🏻) with or without version FFS.

### Android
Fix [#1643](https://github.com/miguelpruivo/flutter_file_picker/issues/1643)

## 8.1.5
### Android
Fix [#872](https://github.com/miguelpruivo/flutter_file_picker/issues/872)
Expand Down
15 changes: 5 additions & 10 deletions android/src/main/java/com/mr/flutter/plugin/filepicker/FilePickerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,16 +254,11 @@ public void onCancel(final Object arguments) {
});
this.observer = new LifeCycleObserver(activity);

if (registrar != null) {
// V1 embedding setup for activity listeners.
application.registerActivityLifecycleCallbacks(this.observer);
registrar.addActivityResultListener(this.delegate);
} else {
// V2 embedding setup for activity listeners.
activityBinding.addActivityResultListener(this.delegate);
this.lifecycle = FlutterLifecycleAdapter.getActivityLifecycle(activityBinding);
this.lifecycle.addObserver(this.observer);
}
// V2 embedding setup for activity listeners.
activityBinding.addActivityResultListener(this.delegate);
this.lifecycle = FlutterLifecycleAdapter.getActivityLifecycle(activityBinding);
this.lifecycle.addObserver(this.observer);

}

private void tearDown() {
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: A package that allows you to use a native file explorer to pick sin
homepage: https://github.com/miguelpruivo/plugins_flutter_file_picker
repository: https://github.com/miguelpruivo/flutter_file_picker
issue_tracker: https://github.com/miguelpruivo/flutter_file_picker/issues
version: 8.1.5
version: 8.1.6

dependencies:
flutter:
Expand Down
Loading