Prevent DI Configuration HttpClient from being overwritten on init #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure the Configuration is used that is supplied during DI.
At the moment the
Configuration.HttpClient
is being overwritten becauseImageServiceBase.InitializeIfNeeded
will always at least run once. The line below will always override the implementation done via DI sinceuserDefinedConfig
will always be null when it's initialized the first time.FFImageLoading.Maui/source/FFImageLoading.Maui/Foundations/ImageServiceBase.cs
Line 124 in 408bdb6
This should be the preferred way to configure FFImageLoading but at the moment it doesn't work because of the above issue.