Remediate Unsafe PAT Usage #2052
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from using Personal Access Token (PATs) to using Application Service Principal and Managed Identities
thewahome
reviewed
May 17, 2024
GraphWebApi/wwwroot/OpenApi.yaml
Outdated
Comment on lines
5
to
11
| servers: | ||
| - url: https://graphexplorerapi.azurewebsites.net/ | ||
| - url: https://devxapi-func-prod-eastus.azurewebsites.net/ | ||
| description: Main server | ||
| - url: https://graphexplorerapi-staging.azurewebsites.net/ | ||
| - url: https://devxapi-func-ppe-eastus.azurewebsites.net/ | ||
| description: Staging server | ||
| - url: https://localhost:44399/ | ||
| description: Local test server |
There was a problem hiding this comment.
Though it's not part of the work on this PR, it could possibly be something to do in a new PR, could we move the server definitions to the pipeline?
There was a problem hiding this comment.
Let's also keep the old servers and add the new ones to the list
musale
reviewed
May 20, 2024
musale
reviewed
May 20, 2024
Co-authored-by: Musale Martin <[email protected]>
Co-authored-by: Musale Martin <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using Personal Access Token (PATs) to using Application Service Principal and Managed Identities
Overview
This PR contains implementation of Authentication using Federated Managed Identity. This remediated usage of unsafe Personal Access Token (PAT).
This PR also contains updated to the OpenAPI.yml server addresses to point to the Torus addresses for DevX API
Notes
Managed Identities are only available to Azure resources that you associate the Managed Identity with. You can only use the Managed Identity from a Torus-hosted Azure resource you've linked your Managed Identity to.
Microsoft Reviewers: Open in CodeFlow