Allow the name and value in set_string
to be 2 different types
#3412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
windows_registry::key::Key::set_string
takes one generic typeT
which implementsAsRef<str>
, which is the type of the argumentsname
andvalue
. This signature is too restrictive, since both arguments must be of the same concrete type, while it should accept, for example,key.set_string(String::from("Name"),"Value")
.This PR adds a new generic type
U
, with the same trait bound asT
and which is the type ofvalue
, thereby allowing the aforementioned situation and similar cases where the 2 arguments have different concrete types that fulfill the same trait bound.