Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler bindings generation #3367

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Simpler bindings generation #3367

merged 1 commit into from
Dec 9, 2024

Conversation

kennykerr
Copy link
Collaborator

Thanks to #3359, bindings for Win32 APIs can mostly ignore the artificial namespaces imposed by the metadata format. This simplifies the maintenance of binding generation scripts.

All I've done here is (1) remove the explicit namespace for types and (2) sorted alphabetically.

@kennykerr
Copy link
Collaborator Author

@ChrisDenton just fyi - no need to do this for rust-lang but its an option if you find its simpler to maintain.

@ChrisDenton
Copy link
Collaborator

It does look much simpler both for contributors and maintainers. Not least because it won't break if something is moved to another namespace.

@kennykerr
Copy link
Collaborator Author

Yep, that's a good point.

@kennykerr kennykerr merged commit 8fb1736 into master Dec 9, 2024
75 checks passed
@kennykerr kennykerr deleted the simpler-bindings branch December 9, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants