Prompt for missing tools when config changes

microsoft · Jun 1, 2018 · 641c783 · 641c783
1 parent f78d12d
commit 641c783
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/Go-latest.vsix b/Go-latest.vsix
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "Go",
-  "version": "0.6.81-beta.3",
+  "version": "0.6.81-beta.4",
   "publisher": "ms-vscode",
   "description": "Rich Go language support for Visual Studio Code",
   "author": {

diff --git a/src/goMain.ts b/src/goMain.ts
@@ -19,7 +19,7 @@ import { GoSignatureHelpProvider } from './goSignature';
 import { GoWorkspaceSymbolProvider } from './goSymbol';
 import { GoCodeActionProvider } from './goCodeAction';
 import { check, removeTestStatus, notifyIfGeneratedFile } from './goCheck';
-import { updateGoPathGoRootFromConfig, offerToInstallTools } from './goInstallTools';
+import { updateGoPathGoRootFromConfig, offerToInstallTools, promptForMissingTool } from './goInstallTools';
 import { GO_MODE } from './goMode';
 import { showHideStatus } from './goStatus';
 import { toggleCoverageCurrentPackage, getCodeCoverage, removeCodeCoverage } from './goCover';
@@ -308,6 +308,15 @@ export function activate(ctx: vscode.ExtensionContext): void {
 			referencesCodeLensProvider.setEnabled(updatedGoConfig['enableCodeLens']['references']);
 		}
 
+		if (e.affectsConfiguration('go.formatTool')) {
+			checkToolExists(updatedGoConfig['formatTool']);
+		}
+		if (e.affectsConfiguration('go.lintTool')) {
+			checkToolExists(updatedGoConfig['lintTool']);
+		}
+		if (e.affectsConfiguration('go.docsTool')) {
+			checkToolExists(updatedGoConfig['docsTool']);
+		}
 	}));
 
 	ctx.subscriptions.push(vscode.commands.registerCommand('go.test.generate.package', () => {
@@ -478,3 +487,9 @@ function sendTelemetryEventForConfig(goConfig: vscode.WorkspaceConfiguration) {
 function didLangServerConfigChange(e: vscode.ConfigurationChangeEvent): boolean {
 	return e.affectsConfiguration('go.useLanguageServer') || e.affectsConfiguration('go.languageServerFlags') || e.affectsConfiguration('go.languageServerExperimentalFeatures');
 }
+
+function checkToolExists(tool: string) {
+	if (tool === getBinPath(tool)) {
+		promptForMissingTool(tool);
+	}
+}