Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edsanche/431 add retention policy duration to powerplatform environment settings #527

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eduardodfmex
Copy link
Contributor

This pull request introduces a new attribute, log_retention_period_in_days, to the environment settings data source, DTO, and models, along with corresponding test updates. The changes ensure that the retention period for audit logs can be optionally specified and computed.

Key changes include:

Schema and Models Updates:

  • Added log_retention_period_in_days attribute to the EnvironmentSettingsDataSource schema in datasource_environment_settings.go.
  • Added AuditRetentionPeriodV2 field to the environmentSettingsDto struct in dto.go.
  • Updated AuditSettingsSourceModel to include log_retention_period_in_days in models.go.

Conversion Functions:

  • Modified convertFromEnvironmentSettingsModel to handle AuditRetentionPeriodV2 in models.go.
  • Updated convertFromEnvironmentSettingsDto to map AuditRetentionPeriodV2 to log_retention_period_in_days in models.go.

Test Updates:

  • Added checks for log_retention_period_in_days in various test functions in datasource_environment_settings_test.go [1] and resource_environment_settings_test.go [2] [3] [4] [5] [6] [7].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retention_policy_duration to powerplatform_environment_settings
1 participant