Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Militm/486 powerplatform analytics data export #504

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

militm
Copy link

@militm militm commented Oct 24, 2024

This pull request introduces support for Power Platform Analytics by adding new configuration URLs, constants, and data models. The changes include updates to the configuration files, creation of new data transfer objects (DTOs) and models, and implementation of API client methods for analytics data export.

Configuration Updates:

  • Added PowerPlatformAnalyticsUrl to ProviderConfigUrls in internal/config/config.go.
  • Introduced PUBLIC_POWERPLATFORM_ANALYTICS_API_DOMAIN constant in internal/constants/constants.go.
  • Updated getCloudPublicUrls function to include PowerPlatformAnalyticsUrl in internal/provider/provider.go.

New Data Models and DTOs:

  • Created AnalyticsDataDto, AnalyticsDataCreateDto, EnvironmentDto, and SinkDto in internal/services/powerplatform_analytics_data_export/analytics_data_export_dto.go.
  • Added AnalyticsDataModel, Environment, Sink, and Status structs in internal/services/powerplatform_analytics_data_export/analytics_data_export_model.go.

API Client Implementation:

  • Implemented NewTelemetryExport, Client, GetAnalyticsDataExport, and CreateAnalyticsDataExport methods in internal/services/powerplatform_analytics_data_export/api_analytics_data_export.go.

Copy link
Member

@mattdot mattdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. keep working on it.

Copy link
Member

@mattdot mattdot Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the change is in codeowners file, but it should not be in your PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE should not be updated by your pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to find and add the analytics api domain for the sovereign clouds as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add powerplatformanalyticsurl to sovereign clouds as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants