Implement central package versioning #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet projects which package SDK binaries are no longer in use and have been disabled. SF.AspNetCore.Internal is the only one left in use and it has been left enabled.
Downgrading package versions to match support policy of package based .NET Core.
NuGet projects which generate NuGet packages are no longer in use and have been deleted. SF.AspNetCore.Internal is the only one left in use and it has been left enabled.
gobradovic
approved these changes
Nov 18, 2024
olegsych
approved these changes
Nov 18, 2024
plave0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many dependencies are shared between projects. Central package management (CPM) prevents discrepancies of dependency versions between projects and reduces the duplication of version information across projects.
Previously, versions of transitive dependencies which have been marked as vulnerable have been overwritten to safe versions. CPM enables us to overwrite versions of vulnerable transitive dependencies in a centralized manner, which makes maintaining them easier. This change also enables us to exclude information about overwritten transitive dependencies from each individual project, which reduces clutter in project files.
Remove unused NuGet projects.
After implementing CPM, NuGet projects (all projects under the
nuprojdirectory, exceptSF.ActorsServices.Internal) started causing warning on build. Since they are no longer in use, and it is not planned to use them in the future, they have been deleted form the repository.Update versions of ASP.NET Core NuGet packages
Update the following packages:
Microsoft.AspNetCore.Diagnosticshas been downgraded to version2.1.1.Microsoft.AspNetCore.Hostinghas been downgraded to version2.1.1.Microsoft.AspNetCore.HttpsPolicyhas been downgraded to version2.1.1.Microsoft.AspNetCore.Mvchas been downgraded to version2.1.3.Microsoft.AspNetCore.Server.HttpSyshas been downgraded to version2.1.12.These packages have been downgraded in order to reflect the support policy of NuGet based ASP.NET Core 2.1 packages which are being used for building our .NET Framework 4.6 packages (https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core).