-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling .NET 9 tests for SF SDK packages #390
Conversation
@olegsych, these are the changes I made for now. When running
This does not happen for the other suits where I enabled .NET 9 tests. Do this error messages look familiar? |
@olegsych, also, |
@plave0 I think the solution may not be setup to build both net8.0 and net9.0 binaries at the same time. Try specifying only I suspect the problem preventing .NET 9 tests from running in addition to .NET 8 is here: https://github.com/microsoft/service-fabric-services-and-actors-dotnet/blob/develop/properties/service_fabric_common.props#L10. I'm not sure why we are overriding the |
We seem to be having a lot of scope creep and I want us to have a meaningful result to demo on Monday. So if you can get the tests running on .NET 9, without .NET 8, I think that might be a good stopping point for this PR. Making the solution build projects with additional folder for target framework could need more changes and we don't have much time left. So I would start that as a separate pull request next. |
Reverting to building tests only for .NET 9 to resolve issues when targeting multiple frameworks.
@olegsych, I agree with your suggestion. I have reverted back to targeting only .NET 9. |
Microsoft.ServiceFabric.Service.Remoting.Tests has been ported to .NET 9 and modified to include BinaryFormatter compatibility package.
Disabling building of tests suits for testing purposes
3e1aa70
to
2996779
Compare
...ServiceFabric.Services.Remoting.Tests/Microsoft.ServiceFabric.Services.Remoting.Tests.csproj
Show resolved
Hide resolved
...ServiceFabric.Services.Remoting.Tests/Microsoft.ServiceFabric.Services.Remoting.Tests.csproj
Outdated
Show resolved
Hide resolved
...ServiceFabric.Services.Remoting.Tests/Microsoft.ServiceFabric.Services.Remoting.Tests.csproj
Show resolved
Hide resolved
We are still unable to use code.sln for building the repo, since it doesn't include SF.ActorsServices.Internal. We will insted build buildAll.proj for now.
This PR enables tests for .NET 9 builds.
Compatibility with the deprecated BinaryFormatter has been introduced so that .NET 9 tests can be enabled.
Additionally, we are moving away from the
buils.ps1
script, which usesmsbuild
under the hood. Instead, we are moving to thedotnet
tool, in the aim of streamlining the build process and infrastructure.Internal ADO work item: https://dev.azure.com/msazure/One/_workitems/edit/29603235