Fix CancelOnTimerWithLargeRetryDelay test flakiness due to Stopwatch imprecision #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imprecision (#381) CancelOnTimerWithLargeRetryDelay fails on some environments due to the fact that Stopwatch class may report incorrect timing results on different processors, as noted in official documentation: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.stopwatch?view=net-8.0 Add error margin to account for Stopwatch imprecision Apply the fix to the CancelOnTimer test as well
olegsych
reviewed
Sep 5, 2024
test/unittests/Microsoft.ServiceFabric.Services.Tests/ServicePartitionClientTests.cs
Outdated
Show resolved
Hide resolved
olegsych
approved these changes
Sep 5, 2024
olegsych
approved these changes
Sep 6, 2024
gobradovic
deleted the
user/gobradovic/fixStopwatchBugInCancelOnTimerWithLargeRetryDelayTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of following PR: #381
CancelOnTimerWithLargeRetryDelay fails on some environments due
to the fact that Stopwatch class may report incorrect timing results on
different processors, as noted in official documentation:
https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.stopwatch?view=net-8.0
Internal ADO work item: https://dev.azure.com/msazure/One/_workitems/edit/29276368