-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NuGet packages to latest versions #374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FluentAssertions from 5.9.0 to 6.12.0 - Moq from 4.13.0 to 4.20.70 - Microsoft.NET.Test.Sdk from 15.9.0 to 17.10.0 - xunit from 2.4.1 to 2.8.1 - xunit.runner.visualstudio from 2.4.1 to 2.8.1 - Replace blocking .GetAwaiter().GetResult() and .Wait() flagged by Xunit analyzers with async/await - Replace Castle.Core IsNullOrEmpty extension method calls with System.Collections.Generic .Any() because the Castle API doesn't recognize nullable reference types.
@pakunapamsft, @gobradovic-MSFT could you review this? |
...ServiceFabric.Services.Remoting.Tests/Microsoft.ServiceFabric.Services.Remoting.Tests.csproj
Show resolved
Hide resolved
gobradovic-MSFT
approved these changes
Jun 19, 2024
pakunapamsft
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided a comment, PTAL.
src/Microsoft.ServiceFabric.Services.Remoting/Microsoft.ServiceFabric.Services.Remoting.csproj
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository was flagged for using unsecure Newtonsoft.Json package version through the xunit package dependency. In addition to the xunit packages, upgrade all packages to their latest stable versions.
Dependencies of the shipping product binaries:
Dependencies of the test projects: