Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NuGet packages to latest versions #374

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

olegsych
Copy link
Member

@olegsych olegsych commented Jun 19, 2024

This repository was flagged for using unsecure Newtonsoft.Json package version through the xunit package dependency. In addition to the xunit packages, upgrade all packages to their latest stable versions.

Dependencies of the shipping product binaries:

  • Microsoft.ServiceFabric.Services.Remoting
    • System.Reflection.Emit and System.Reflection.Emit.ILGeneration from 4.3.0 to 4.7.0
    • System.Diagnostics.DiagnosticSource from 4.3.0 to 8.0.1

Dependencies of the test projects:

  • FluentAssertions from 5.9.0 to 6.12.0
  • Moq from 4.13.0 to 4.20.70
  • Microsoft.NET.Test.Sdk from 15.9.0 to 17.10.0
  • xunit from 2.4.1 to 2.8.1
  • xunit.runner.visualstudio from 2.4.1 to 2.8.1
  • Microsoft.Diagnostics.Tracing.TraceEvent from 2.0.45 to 3.1.12
  • System.Net.Http.WinHttpHandler from 6.0.0 to 8.0.0

olegsych added 6 commits June 19, 2024 14:16
- FluentAssertions from 5.9.0 to 6.12.0
- Moq from 4.13.0 to 4.20.70
- Microsoft.NET.Test.Sdk from 15.9.0 to 17.10.0
- xunit from 2.4.1 to 2.8.1
- xunit.runner.visualstudio from 2.4.1 to 2.8.1
- Replace blocking .GetAwaiter().GetResult() and .Wait() flagged by Xunit analyzers with async/await
- Replace Castle.Core IsNullOrEmpty extension method calls with System.Collections.Generic .Any() because the Castle API doesn't recognize nullable reference types.
@olegsych olegsych marked this pull request as ready for review June 19, 2024 23:20
@olegsych olegsych requested a review from pakunapamsft June 19, 2024 23:20
@olegsych olegsych self-assigned this Jun 19, 2024
@olegsych olegsych requested a review from gobradovic-MSFT June 19, 2024 23:21
@olegsych
Copy link
Member Author

@pakunapamsft, @gobradovic-MSFT could you review this?

Copy link
Contributor

@pakunapamsft pakunapamsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided a comment, PTAL.

@olegsych olegsych merged commit c732020 into develop Jun 20, 2024
2 checks passed
@olegsych olegsych deleted the user/olegsych/UpgradeNewtonsoft.Json branch June 20, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants