-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read Logical Time Manager timestamp from the actor state #356
Merged
yashagarwal23
merged 10 commits into
microsoft:develop
from
yashagarwal23:yashagarwal/develop/fix-logical-time-manager2
Nov 21, 2023
Merged
Read Logical Time Manager timestamp from the actor state #356
yashagarwal23
merged 10 commits into
microsoft:develop
from
yashagarwal23:yashagarwal/develop/fix-logical-time-manager2
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make StateProviderInitRetryDelayMilliseconds a const field Wait for Logical Time Manager to start before loading reminders Rename InitializeAndStartLogicalTimeManager
yashagarwal23
changed the title
[Draft] KVSActorStateProvider: Read Logical Time Manager timestamp from the actor state
Read Logical Time Manager timestamp from the actor state
Nov 2, 2023
pakunapamsft
approved these changes
Nov 7, 2023
src/Microsoft.ServiceFabric.Actors/Runtime/VolatileActorStateProvider.cs
Show resolved
Hide resolved
src/Microsoft.ServiceFabric.Actors/Runtime/VolatileActorStateProvider.cs
Show resolved
Hide resolved
yashagarwal23
deleted the
yashagarwal/develop/fix-logical-time-manager2
branch
November 21, 2023 11:24
yashagarwal23
added a commit
that referenced
this pull request
Feb 1, 2024
* Add AnyCPU configuration in code.sln * Read the logical time manager value from the state provider Make StateProviderInitRetryDelayMilliseconds a const field Wait for Logical Time Manager to start before loading reminders Rename InitializeAndStartLogicalTimeManager * Remove extra ReleaseAssert * minor variable name change * Read LogicalTimeManager Timestamp from state for VolatileActorStateProvider also * KVS: Better exception handling; wait for read status * Volatile: Better exception handling; wait for read status * Add traces when waiting for WriteStatus to be Granted * resolve some comments
yashagarwal23
added a commit
that referenced
this pull request
Feb 1, 2024
* Add AnyCPU configuration in code.sln * Read the logical time manager value from the state provider Make StateProviderInitRetryDelayMilliseconds a const field Wait for Logical Time Manager to start before loading reminders Rename InitializeAndStartLogicalTimeManager * Remove extra ReleaseAssert * minor variable name change * Read LogicalTimeManager Timestamp from state for VolatileActorStateProvider also * KVS: Better exception handling; wait for read status * Volatile: Better exception handling; wait for read status * Add traces when waiting for WriteStatus to be Granted * resolve some comments
yashagarwal23
added a commit
that referenced
this pull request
Feb 1, 2024
* Add AnyCPU configuration in code.sln * Read the logical time manager value from the state provider Make StateProviderInitRetryDelayMilliseconds a const field Wait for Logical Time Manager to start before loading reminders Rename InitializeAndStartLogicalTimeManager * Remove extra ReleaseAssert * minor variable name change * Read LogicalTimeManager Timestamp from state for VolatileActorStateProvider also * KVS: Better exception handling; wait for read status * Volatile: Better exception handling; wait for read status * Add traces when waiting for WriteStatus to be Granted * resolve some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the Logical Time Manager Timestamp from the state for in KVS and Volatile Actor State Provider. We already do that for ReliableCollectionsActorStateProvider.