-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Introducing search for CosmosDB NoSQL Collections #9698
Open
eavanvalkenburg
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
eavanvalkenburg:cos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+160
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Pull requests for the Python Semantic Kernel
memory
labels
Nov 14, 2024
TaoChenOSU
approved these changes
Nov 14, 2024
@@ -91,7 +91,9 @@ async def _does_database_exist(self) -> bool: | |||
except CosmosResourceNotFoundError: | |||
return False | |||
except Exception as e: | |||
raise MemoryConnectorResourceNotFound(f"Failed to check if database '{self.database_name}' exists.") from e | |||
raise MemoryConnectorResourceNotFound( | |||
f"Failed to check if database '{self.database_name}' exists, with message {e}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my education: will this duplicate the original exception message?
Should we add an integration test case that test inserting multiple records across partitions? |
alliscode
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds the search functions for Cosmos DB NoSQL.
Closes #6835
Description
Adds the search pieces and turns out the upsert cannot work cross partition key with execute batch, so refactored to using gather(upsert).
Contribution Checklist