Skeleton app for containerization #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
approved these changes
Jan 8, 2025
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <RuntimeIdentifiers>win-x64;win-arm64;linux-x64;linux-arm64;</RuntimeIdentifiers> | ||
| <TargetFramework>net8.0</TargetFramework> |
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net8.0</TargetFramework> | |
| <TargetFramework>net9.0</TargetFramework> |
If we're the only ones expected to build this, can we just always use the latest?
There was a problem hiding this comment.
We are the only one, but since it will be used in a Dockerfile in another repo, I prefer keeping the target framework explicitely fixed
There was a problem hiding this comment.
If you mean hardcoding the TFM instead of using the variable, that's fine by me.
I was mainly asking about 8.0 vs 9.0.
I see you currently have it build both - how come not just 9.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic application to be used in the future container.
It relies on yarp nuget packages for now because of the dependency to aspire service discovery.