Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable code analyzers #2683

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

MihaZupan
Copy link
Member

Brings in CodeAnalysis.src.globalconfig and CodeAnalysis.test.globalconfig from dotnet/runtime.

The config is the same, with the exception of

// Disabled because we still target .NET 6.0
SYSLIB1045: Convert to 'GeneratedRegexAttribute'.
CA1510: Use ArgumentNullException throw helper

// Disabled because it's too late / we don't care
CA1727: Use PascalCase for named placeholders
CA2007: Consider calling ConfigureAwait on the awaited task

// Disabled in tests
xUnit1004: Test methods should not be skipped

@MihaZupan MihaZupan added this to the YARP 2.3 milestone Dec 12, 2024
@MihaZupan MihaZupan self-assigned this Dec 12, 2024
@MihaZupan MihaZupan merged commit d4f1a5c into microsoft:main Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants