Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade nx to 12.10.1 #2561

Merged
merged 1 commit into from
May 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions .github/workflows/CI-raiwidgets-pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ jobs:
- packageDirectory: "raiwidgets"
operatingSystem: windows-latest
pythonVersion: 3.8
- packageDirectory: "raiwidgets"
operatingSystem: macos-latest
pythonVersion: 3.7

runs-on: ${{ matrix.operatingSystem }}

Expand All @@ -41,34 +44,50 @@ jobs:
with:
node-version: ${{ env.node-version }}

- name: Install yarn
run: npm install yarn -g

- name: Install yarn dependencies
run: yarn install --frozen-lock-file

- name: Build Typescript
run: yarn buildall

- if: ${{ matrix.operatingSystem == 'macos-latest' }}
name: Install latest numpy from conda-forge for MacOS
shell: bash -l {0}
run: |
conda install --yes --quiet -c conda-forge numpy

- if: ${{ matrix.operatingSystem == 'macos-latest' }}
name: Use Homebrew to install libomp on MacOS
shell: bash -l {0}
run: |
brew install libomp

- if: ${{ matrix.operatingSystem == 'macos-latest' }}
name: Install latest lightgbm from conda-forge for MacOS
shell: bash -l {0}
run: |
conda install --yes --quiet lightgbm -c conda-forge

- if: ${{ matrix.operatingSystem == 'macos-latest' }}
name: Install macos node-gyp dependencies for build
shell: bash -l {0}
run: |
brew install cairo
brew install pango

- name: Setup tools
shell: bash -l {0}
run: |
python -m pip install --upgrade pip
pip install --upgrade setuptools
pip install --upgrade "pip-tools<=7.1.0"

- name: Install yarn
shell: bash -l {0}
run: npm install yarn -g

- name: Install yarn dependencies
shell: bash -l {0}
run: yarn install --frozen-lock-file

- name: Build Typescript
shell: bash -l {0}
run: yarn buildall

- name: Install dependencies
shell: bash -l {0}
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/CI-typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [14.x, 16.x]

steps:
- uses: actions/checkout@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ export function describeSubBarChart(dataShape: IInterpretData): void {
);
});
it("should have right number of x axis labels", () => {
// This is usually 4, so less than or equal to number of features
cy.get("#FeatureImportanceBar g.highcharts-xaxis-labels text")
.its("length")
.should("be", props.dataShape.featureNames.length);
.should("lte", props.dataShape.featureNames.length);
});
});
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function checkNumLabels(
): void {
cy.get(`${locator} g.highcharts-xaxis-labels text`)
.its("length")
.should("be", expectedNumLabels);
.should("eq", expectedNumLabels);
}

export function validateBarChart(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ export function describeModelOverview(
);
});

it("should show 'Feature cohorts' view when selected", () => {
// Skipping due to issues with combobox selection being very flaky
it.skip("should show 'Feature cohorts' view when selected", () => {
ensureAllModelOverviewBasicElementsArePresent(datasetShape);
cy.get(Locators.ModelOverviewCohortViewFeatureCohortViewButton).click();
ensureAllModelOverviewFeatureCohortsViewBasicElementsArePresent(
Expand All @@ -85,7 +86,8 @@ export function describeModelOverview(
);
});

it("should show 'Feature cohorts' view with multiple features when selected", () => {
// Skipping due to issues with combobox selection being very flaky
it.skip("should show 'Feature cohorts' view with multiple features when selected", () => {
cy.get(Locators.ModelOverviewFeatureSelection).click();
multiSelectComboBox(
"#modelOverviewFeatureSelection",
Expand Down
31 changes: 16 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
},
"dependencies": {
"@fluentui/react": "8.58.0",
"@yarnpkg/parsers": "3.0.0-rc.48.1",
"canvas": "^2.11.2",
"core-js": "^3.6.5",
"d3-array": "^3.2.4",
Expand Down Expand Up @@ -79,17 +80,17 @@
"@babel/preset-env": "7.11.0",
"@babel/preset-react": "7.10.4",
"@babel/preset-typescript": "7.10.4",
"@nrwl/cli": "12.6.2",
"@nrwl/cypress": "12.6.2",
"@nrwl/eslint-plugin-nx": "12.6.2",
"@nrwl/jest": "12.6.2",
"@nrwl/react": "12.6.2",
"@nrwl/tao": "12.6.2",
"@nrwl/web": "12.6.2",
"@nrwl/workspace": "12.6.2",
"@nrwl/cli": "12.10.0",
"@nrwl/cypress": "12.10.0",
"@nrwl/eslint-plugin-nx": "12.10.0",
"@nrwl/jest": "12.10.0",
"@nrwl/react": "12.10.0",
"@nrwl/tao": "12.10.0",
"@nrwl/web": "12.10.0",
"@nrwl/workspace": "12.10.0",
"@rollup/plugin-json": "4.1.0",
"@svgr/rollup": "5.4.0",
"@testing-library/react": "11.2.5",
"@testing-library/react": "11.2.6",
"@types/d3-array": "^3.2.1",
"@types/d3-color": "^3.1.3",
"@types/d3-hierarchy": "^3.1.6",
Expand All @@ -100,7 +101,7 @@
"@types/d3-zoom": "^3.0.8",
"@types/enzyme": "3.10.5",
"@types/enzyme-to-json": "1.5.3",
"@types/jest": "26.0.8",
"@types/jest": "27.0.2",
"@types/jmespath": "^0.15.0",
"@types/jszip": "^3.4.1",
"@types/lodash": "4.14.159",
Expand All @@ -116,11 +117,11 @@
"@typescript-eslint/eslint-plugin": "4.28.4",
"@typescript-eslint/parser": "4.28.4",
"@wojtekmaj/enzyme-adapter-react-17": "0.6.6",
"babel-jest": "26.2.2",
"babel-jest": "27.2.3",
"commander": "^7.1.0",
"cross-env": "7.0.2",
"cypress": "^4.12.1",
"dotenv": "8.2.0",
"cypress": "^5.6.0",
"dotenv": "10.0.0",
"enzyme": "3.11.0",
"enzyme-to-json": "3.5.0",
"eslint": "7.22.0",
Expand All @@ -134,7 +135,7 @@
"eslint-plugin-react": "7.23.1",
"eslint-plugin-react-hooks": "4.2.0",
"eslint-plugin-unicorn": "21.0.0",
"jest": "27.0.3",
"jest": "27.2.3",
"jest-canvas-mock": "2.2.0",
"jszip": "3.10.1",
"moment-timezone": "0.5.35",
Expand All @@ -144,7 +145,7 @@
"raw-loader": "^4.0.2",
"semver": "7.3.2",
"serve": "11.3.2",
"ts-jest": "27.0.3",
"ts-jest": "27.0.5",
"ts-node": "9.1.1",
"typescript": "4.3.5",
"worker-loader": "^3.0.8"
Expand Down
Loading
Loading