Raise usererror on prediction failure. #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
kicha0
force-pushed
the
kicha/main/raise_user_error_on_prediction_failure
branch
3 times, most recently
from
31a1514
to
483593c
Compare
kicha0
commented
Aug 24, 2023
responsibleai_text/responsibleai_text/managers/error_analysis_manager.py
Outdated
Show resolved
Hide resolved
1 similar comment
kicha0
force-pushed
the
kicha/main/raise_user_error_on_prediction_failure
branch
from
483593c
to
b7828d8
Compare
1 similar comment
gaugup
approved these changes
Aug 24, 2023
responsibleai_text/responsibleai_text/rai_text_insights/rai_text_insights.py
Outdated
Show resolved
Hide resolved
responsibleai_text/responsibleai_text/rai_text_insights/rai_text_insights.py
Outdated
Show resolved
Hide resolved
imatiach-msft
requested changes
Aug 24, 2023
There was a problem hiding this comment.
It looks like tests are failing with errors and this will make things much slower - any way to avoid this? We only have one component for text so I wonder if we can just catch this where the error occurs in other predict calls instead of here in this validation code?
kicha0
force-pushed
the
kicha/main/raise_user_error_on_prediction_failure
branch
2 times, most recently
from
4fa46a4
to
08073ab
Compare
kicha0
force-pushed
the
kicha/main/raise_user_error_on_prediction_failure
branch
from
08073ab
to
dfe80d6
Compare
2 similar comments
imatiach-msft
approved these changes
Aug 25, 2023
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use full test dataset for validation in rai text insight.
Checklist