-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding linting to the CI steps #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Are we planning to deprioritize fixing E501 - long line error for now?
May be add it to the backlog in that case and we can pick it up later if time permits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add flake8 as a pre-commit hook so that it runs locally before commits are pushed for a PR?
This will ensure that the linter is run on code locally before it is put up for PR.
#262 Issue to track the remaining lint error |
Issue to track the remaining error - #262
Proof that lint errors block the PR:
Adding test coverage config. It was already added in Test coverage config #243. But for some reason was not merged in.
Fixing some lint errors that accumulated