Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding linting to the CI steps #260

Merged
merged 16 commits into from
Jan 10, 2024
Merged

Conversation

anastasia-linzbach
Copy link
Collaborator

@anastasia-linzbach anastasia-linzbach commented Jan 8, 2024

  1. Adding flake8 step to CI. For now all lint errors except "Line is too long" (E501) are fixed. Current approach is to exclude this type of error.

Issue to track the remaining error - #262

Proof that lint errors block the PR:
image

  1. Adding hook to run flake8 before commit
image
  1. Adding test coverage config. It was already added in Test coverage config #243. But for some reason was not merged in.

  2. Fixing some lint errors that accumulated

Copy link
Collaborator

@rasavant-ms rasavant-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Are we planning to deprioritize fixing E501 - long line error for now?
May be add it to the backlog in that case and we can pick it up later if time permits.

Copy link
Collaborator

@rasavant-ms rasavant-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add flake8 as a pre-commit hook so that it runs locally before commits are pushed for a PR?
This will ensure that the linter is run on code locally before it is put up for PR.

@anastasia-linzbach
Copy link
Collaborator Author

#262 Issue to track the remaining lint error

.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@anastasia-linzbach anastasia-linzbach merged commit e347aaf into development Jan 10, 2024
3 checks passed
@julia-meshcheryakova julia-meshcheryakova deleted the flake8-to-ci-steps branch February 9, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants