Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOC header and card list roles in docs #9971

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Apr 15, 2024

Fixes microsoft/pxt-microbit#5475
Fixes microsoft/pxt-arcade#4869

Also fixes the roles for the search box in the menubar @srietkerk FYI (sorry, I thought this was part of my bug. hopefully you weren't working on it)

While I was at it, I also removed some semantic ui stuff (but not all of it)

@riknoll riknoll requested a review from a team April 15, 2024 23:57
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't working on this, so no problem! Nice!

@riknoll riknoll merged commit 948b36f into master Apr 16, 2024
7 checks passed
@riknoll riknoll deleted the dev/riknoll/access-bugs branch April 16, 2024 16:19
riknoll added a commit that referenced this pull request Apr 16, 2024
riknoll added a commit that referenced this pull request Apr 16, 2024
* Revert "Fix various docs/homepage accessibility bugs (#9974)"

This reverts commit d13b8a3.

* Revert "Fix TOC header and card list roles in docs (#9971)"

This reverts commit 948b36f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants