Add restore command and keep translations when updating #9966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Apr 11, 2024
riknoll
added a commit
that referenced
this pull request
Apr 12, 2024
* add restore command and keep translations when updating * add --test flag * add parameter to prevent accidental runs
riknoll
added a commit
that referenced
this pull request
Apr 12, 2024
riknoll
added a commit
that referenced
this pull request
Apr 30, 2024
riknoll
added a commit
that referenced
this pull request
Apr 30, 2024
…branch (#9991) * [V9] Cherry picking crowdin work over to v9 branch (#9963) * Upgrade to Crowdin V2 APIs (#9954) * use crowdin v2 apis * rename crowdin API * add projectid setting * fix test mode * copy pxt-translations crowdin config * re-enable crowdin stats (#9962) * Add restore command and keep translations when updating (#9966) (#9968) * add restore command and keep translations when updating * add --test flag * add parameter to prevent accidental runs
riknoll
added a commit
that referenced
this pull request
May 8, 2024
…branch (#9991) * [V9] Cherry picking crowdin work over to v9 branch (#9963) * Upgrade to Crowdin V2 APIs (#9954) * use crowdin v2 apis * rename crowdin API * add projectid setting * fix test mode * copy pxt-translations crowdin config * re-enable crowdin stats (#9962) * Add restore command and keep translations when updating (#9966) (#9968) * add restore command and keep translations when updating * add --test flag * add parameter to prevent accidental runs
riknoll
added a commit
that referenced
this pull request
May 17, 2024
…necraft stable (#10009) * [stable9.0] Cherry picking crowdin changes over to Calliope's stable branch (#9991) * [V9] Cherry picking crowdin work over to v9 branch (#9963) * Upgrade to Crowdin V2 APIs (#9954) * use crowdin v2 apis * rename crowdin API * add projectid setting * fix test mode * copy pxt-translations crowdin config * re-enable crowdin stats (#9962) * Add restore command and keep translations when updating (#9966) (#9968) * add restore command and keep translations when updating * add --test flag * add parameter to prevent accidental runs * hide asset name when assetEditor is false (#9878) * Fixes for image editor in micro:bit (#9900) * fix compile variants when palette is in dep * add field editor param for the tagged template * fix help link in monaco flyout (#10008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was testing out my crowdin changes on pxt-ev3, I realized that I accidentally removed all pre-existing translations on the uploaded files when I pushed new versions (even though the new versions didn't actually change anything). The problem was that I didn't include the update mode parameter that we used to include in our API requests. This PR restores that parameter so that when we upload files pre-existing translations stick around but are marked as unapproved.
I also figured it was a good idea to restore the old versions of the pxt-ev3 files, so I added a new crowdin command for bulk restoring old file revisions:
This command restores all files for the target to the most recent revision before the date that is passed in. You can run it with the
--testflag to see exactly what it's going to do without reverting files.Because this is a somewhat dangerous command, you also have to specify "force" at the end of the command string or it won't do anything. e.g.
pxt crowdin restore 1712860596984 force