Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all traces of crowdin branch support #9964

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Apr 11, 2024

As mentioned in #9954, I removed support for crowdin branches with the V2 upgrade. This PR removes the remaining traces of support we had throughout the webapp.

There was surprising amount of code for a crowdin feature that AFAIK we have never used.

@riknoll riknoll requested a review from a team April 11, 2024 17:50
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just curious if you have any context on why we implemented this if we weren't really using it?

@riknoll
Copy link
Member Author

riknoll commented Apr 11, 2024

@srietkerk nope. this code was checked in 8 years ago

@riknoll riknoll merged commit e7602f2 into master Apr 11, 2024
7 checks passed
@riknoll riknoll deleted the dev/riknoll/remove-crowdin-branches branch April 11, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants