Teacher Tool: Only Auto-Run Modified Criteria #9958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks/copilot_criteria
…t sure if we really want to expose this to anyone with a MakeCode iframe yet. I've tried to preserve the structure somewhat so it's easy to move back if desired.
… to anyone with a MakeCode iframe yet. I've tried to preserve the structure somewhat so it's easy to move back if desired.
…ks/copilot_criteria_before_autorun_changes
…ks/copilot_criteria_before_autorun_changes
…ks/auto_run_adjustments
srietkerk
reviewed
Apr 11, 2024
| const existingOutcome = teacherTool.evalResults[criteriaInstance.instanceId]?.result; | ||
| if ( | ||
| !fromUserInteraction && | ||
| existingOutcome !== undefined && |
There was a problem hiding this comment.
I'm fine with this explicit check, so this is a nit. Just wondering if there was as reason as to why this check is explicitly for undefined and isn't just a nullish check? so just having && existingOutcome && ... instead.
There was a problem hiding this comment.
I did that at first, but one of the enum values (EvaluationStatus.Pass) is equal to 0 so that was messing with the nullish check.
eanders-ms
approved these changes
Apr 11, 2024
srietkerk
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With this change, auto-run will only evaluate criteria that have been modified. It will not re-evaluate everything unless the share link changes. If the user presses the run button directly, everything will re-run.
I also changed
PendingtoNotStartedbecause I kept confusingPendingwithInProgress.Why
We want to avoid lots of redundant, expensive calls for criteria that may be expensive to run (like AI checks).
How
I use the evaluation result as a kind of dirty flag. When a criterion is modified (or the share link changes), we reset the outcome to "Not Evaluated", then auto-run only kicks off evaluation for the criteria that have a "Not Evaluated" state.
Also...
I considered adding criteria-level auto-run configuration in addition to this, which would allow us to disable autorun entirely on specific criteria, or to only auto-run certain criteria when the results tab is active (visible), but I held off, since we may combine the rubric and results tabs, at which point, I think that level of config would become much less valuable.