Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt: enable vertical scrolling in modal dialog #9895

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

eanders-ms
Copy link
Collaborator

We should consider porting this to react-common.

@eanders-ms eanders-ms requested a review from a team February 29, 2024 23:59
@eanders-ms eanders-ms self-assigned this Feb 29, 2024
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


.common-modal {
max-height: 90vh;
display: flex;
Copy link
Contributor

@thsparks thsparks Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not already a flex display? I'm surprised.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was shocked!

@eanders-ms eanders-ms merged commit daf04df into master Mar 1, 2024
7 checks passed
@eanders-ms eanders-ms deleted the eanders-ms/modal-scroll branch March 1, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants