teacher tool: misc tidy stuff #9870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsparks
reviewed
Feb 16, 2024
| @@ -2047,7 +2047,6 @@ async function buildSemanticUIAsync(parsed?: commandParser.ParsedCommand) { | |||
| generateReactCommonCss("skillmap"), | |||
| generateReactCommonCss("authcode"), | |||
| generateReactCommonCss("multiplayer"), | |||
| generateReactCommonCss("teachertool") | |||
There was a problem hiding this comment.
I'm surprised. Did something change, or has this always been unnecessary?
There was a problem hiding this comment.
It's always been unnecessary, and was causing the react-common css to be loaded twice. Duplicates of every class.
thsparks
reviewed
Feb 16, 2024
| @@ -7,17 +7,16 @@ | |||
| <meta name="theme-color" content="#000000" /> | |||
| <meta | |||
| name="description" | |||
| content="MakeCode Teacher Tool. Automatically analyze and evaluate projects." | |||
| content="MakeCode Project Insights. Designed to help teachers evaluate student projects using a rubric." | |||
There was a problem hiding this comment.
FYI, don't need to block on this, but in our sync yesterday, there was some disagreement around the name Project Insights. We probably need to have a meeting with branding folks to hash this out.
There was a problem hiding this comment.
Sure. We can keep iterating on it.
thsparks
approved these changes
Feb 16, 2024
|
I merged this rather quickly after opening it. @srietkerk please feel free to leave feedback if you had anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous cleanup items I've been sitting on. I didn't want these included with other changes.