Before compiling, try to fetch built js from backend #9778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riknoll
reviewed
Nov 10, 2023
riknoll
approved these changes
Nov 10, 2023
riknoll
reviewed
Nov 10, 2023
jwunderl
approved these changes
Nov 10, 2023
|
@aznhassan please feel free to merge this when you're ready. |
|
Will this change work without related backend changes? |
|
The backend has an existing |
|
It would be safer to change the endpoint to a new one. Something like |
aznhassan
pushed a commit
that referenced
this pull request
Jan 4, 2024
aznhassan
added a commit
that referenced
this pull request
Jan 5, 2024
* Before compiling, try to fetch built js from backend (#9778) * Track js compilation time (#9794) --------- Co-authored-by: Eric Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pxtrunner, before building the project from source, attempt to fetch the compiled game from the backend.
Tested with run.html and works locally. I'm unsure this is the best approach though, and I don't know if this will work with the share page.