Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code Validation Docs to Include Validate-Exists Marker #9772

Merged

Conversation

thsparks
Copy link
Contributor

@thsparks thsparks commented Nov 2, 2023

Wanted to update the docs to include the changes made in #9675.

These can now be utilized in Minecraft to validate non-highlighted blocks, which is nice!

@thsparks thsparks requested review from kimprice, ganicke, a team and kiki-lee November 2, 2023 22:11
@thsparks
Copy link
Contributor Author

thsparks commented Nov 2, 2023

Hmm it just occurred to me, this will only work in targets that have had a pxt bump since the original change (I think just Minecraft at the moment), so we may need to wait until we've had microbit and arcade releases too...

@thsparks
Copy link
Contributor Author

thsparks commented Nov 6, 2023

Hmm it just occurred to me, this will only work in targets that have had a pxt bump since the original change (I think just Minecraft at the moment), so we may need to wait until we've had microbit and arcade releases too...

Discussed in stand-up and decided it's okay to commit this, since we're really the only ones using it at the moment anyway.

Copy link
Contributor

@kimprice kimprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for writing it up.

@thsparks thsparks merged commit e2ef9cb into master Nov 6, 2023
6 checks passed
@thsparks thsparks deleted the thsparks/update_code_validation_docs_with_validate_exists branch November 6, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants