-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make normalize language code which is not only 2-2 / Add langs #9763
Conversation
@microsoft-github-policy-service agree
|
@sae220 thanks so much for the contribution. I do have a question. What is the reference for the localized name? Like "Wikang Filipino"? In the past there have been cases where people didn't agree with the localized name and we want to be sensitive for the same. If there reference for these localized name let me know. |
I searched the words (like Filipino) on Wikipedia (https://en.wikipedia.org/wiki/Filipino_language) and copied the localized name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this!
Code change looks good, but I believe we'll have to run localizedName through internal translation teams to confirm before releasing the other locales, and we also will have make some changes in another repo / crowdin to get them all fully set up; could you remove the ones besides ja-HIRA
for now since that was the other one we have fully set up otherwise, and we can work on the others separately?
pxtlib/util.ts
Outdated
@@ -1201,30 +1207,41 @@ namespace ts.pxtc.Util { | |||
"is": { englishName: "Icelandic", localizedName: "Íslenska" }, | |||
"it": { englishName: "Italian", localizedName: "Italiano" }, | |||
"ja": { englishName: "Japanese", localizedName: "日本語" }, | |||
"ja-hira": {englishName: "Hiragana", localizedName: "にほんご"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ja-hira": {englishName: "Hiragana", localizedName: "にほんご"}, | |
"ja-HIRA": { englishName: "Hiragana", localizedName: "にほんご" }, |
quick update for consistency, we changed the language code in crowdin already~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a digression but to be precise with RFC 5646, it's one of:
language code
+-
+region
language code
+-
+script
language code
+-
+script
+-
+region
.
Hiragana in this case is a 'script' (style of writing) not a 'region' so it's commonly expressed as ja-Hira
, whereas the region codes are all upper-case.
Refs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I fix to ja-Hira
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not at the moment. That will require a corresponding change in the cloud serving stuff so we'll leave it as-is unless others on the team want to use this format.
OK, if we need to make some changes for inappropriate translation of localizedName, please let me know. |
So what should I do now? |
@sae220 I will take care of review and merging this week (Sorry we are middle of bunch of releases this week) |
I have also removed zh-hk in this change as it needs further legal review.
Per request
We need to find the right localized name.
For tracking here is the internal microsoft site (not publicly available) to the right localized names: https://microsoft.sharepoint.com/sites/globalreadiness/SitePages/Official-Language-Names.aspx |
There are some languages whose code are not 2-2 letters (not like en (2), en-US (2-2) but fil (3), ja-hira (2-4)).
https://crowdin.com/project/makecode/discussions/152