kiosk: Fix for clean=1 param #9762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fun with Swiper idiosyncrasies. When Swiper's
loopoption is enabled, it will duplicate slides until there are three, but it won't distinguish between them when rendering, so you won't know which is actually selected. Transitioning between these duplicated slides doesn't reliably trigger a React re-render. I had to work around this behavior to get the carousel rendering correctly when there were less than three games uploaded and clean=1. @srietkerk this probably sounds familiar to you! :)Fixes microsoft/pxt-arcade#6169
Fixes microsoft/pxt-arcade#6136, incidentally