Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable8.5] cherry-pick all kiosk commits #9743

Merged
merged 37 commits into from
Oct 24, 2023

Conversation

eanders-ms
Copy link
Contributor

No description provided.

eanders-ms and others added 30 commits October 23, 2023 19:57
* Add `--no-webapps' gulp option

* Fix function declaration inconsistency

* docs
* Move kiosk to pxt repo

* sync latest kiosk changes from arcade repo

* Move kiosk config files to arcade docs

* kiosk updates

* update GameDataUrl

* comment missing icon resources

* disable eslint, for now

* fix code scan warning
* Navigation improvements

* add return types

* sound effect tweak

* Add switch sound to Adding Game screen
* New UI effects authored in Arcade

* Update readme

* Clarify readme
* Kiosk: Use pxt.tickEvent

* remove localhost special case
* kiosk: refactor add game polling

* show toast on game delete

* poll for games even while playing a game
* Remove direct dom manipulation

* tweak adding game css

* prettier

* Removed unneeded css attribute

* update readme

* Remove unwanted memo dependency
* Kiosk: Support event-based navigation

* remove unused packages

* Add spacer to add game layout to keep it centered at wide resolutions

* Restore link border on scan qr page

* Shortened background transition time

* Better focus trapping. Fix tab nav on ScanQR page.

* pr feedback

* prettier
* kiosk: download targetconfig.json at startup

* update cli crowdin thing

* Update cli/cli.ts

Co-authored-by: Joey Wunderlich <[email protected]>

---------

Co-authored-by: Joey Wunderlich <[email protected]>
* kiosk: persist built game js in local storage

* better null check
Pushing this through in time for testing today.

* fixes for carousel touch nav, storage exceptions

* don't save compiled js in local storage.
@eanders-ms eanders-ms requested a review from a team October 24, 2023 15:59
Copy link
Collaborator

@abchatra abchatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at all the non-kiosk folder changes and they look good to me.

@eanders-ms
Copy link
Contributor Author

eanders-ms commented Oct 24, 2023

Yes, a few somewhat-related changes crept in, but seemed ok to me too.

@eanders-ms eanders-ms merged commit 8607876 into stable8.5 Oct 24, 2023
4 checks passed
@eanders-ms eanders-ms deleted the eanders-ms/stable8.5/cp-kiosk-2 branch October 24, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants