Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the home screen's project row card size on mobile #9711

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Oct 9, 2023

Fixes https://github.com/microsoft/pxt-minecraft/issues/2243

I also had to make the (+) icon smaller on the new project card and nudge the blocks file image 4 pixels to the left because the svg for it has margins baked in

image

@riknoll riknoll requested a review from a team October 9, 2023 21:24
@kimprice
Copy link
Contributor

kimprice commented Oct 9, 2023

Looks good, but what about the issue when scaling up to full screen?

@riknoll
Copy link
Member Author

riknoll commented Oct 9, 2023

@kimprice that issue doesn't repro for me...

@kimprice
Copy link
Contributor

kimprice commented Oct 9, 2023

@kimprice that issue doesn't repro for me...

hmm me neither actually

@riknoll riknoll merged commit 211f050 into master Oct 9, 2023
7 checks passed
@riknoll riknoll deleted the dev/riknoll/project-card-size branch October 9, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants