Adding certificate preview to the rewards modal and skillmap tests #8592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Nov 11, 2021
shakao
reviewed
Nov 11, 2021
| let [kind, ...value] = reward.split(":"); | ||
|
|
||
| switch (kind) { | ||
| case "certificate": |
There was a problem hiding this comment.
do we need to support this case? the only map that could've been using it (before this current pr changed the syntax) was our own hour of code, right?
There was a problem hiding this comment.
there are a few right now, i can remove this once release shenanigans are settled but best to keep it for now
There was a problem hiding this comment.
sounds good! lgtm otherwise
shakao
approved these changes
Nov 11, 2021
livcheerful
approved these changes
Nov 11, 2021
|
I've updated this PR to also include the necessary change for microsoft/pxt-arcade#4320 @shakao @livcheerful please take a look at the most recent commit |
dmonroym
approved these changes
Nov 15, 2021
riknoll
added a commit
that referenced
this pull request
Nov 17, 2021
…8592) * Adding certificate preview to the rewards modal and skillmap tests * Fix lint and remove extra css * Add the ability to specify a name for the badge
riknoll
added a commit
that referenced
this pull request
Nov 17, 2021
* Adding certificate preview to the rewards modal and skillmap tests (#8592) * Adding certificate preview to the rewards modal and skillmap tests * Fix lint and remove extra css * Add the ability to specify a name for the badge * Make loading start earlier and add locked badges (#8600) * Make loading start earlier and add locked badges * pr feedback * Fix the tilemap wall cursor (#8601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More design changes from @soniakandah